Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1165

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

OleksandraKoshyk
Copy link

DEMO [ https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/]

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. Fix the comments block position, check it on the working example
image
  1. The comment cannot be only spaces
image
  1. Add a correct type to input of email
image

README.md Outdated
@@ -35,3 +35,5 @@ Install Prettier Extention and use this [VSCode settings](https://mate-academy.g
1. Implement comment deletion
- Delete the commnet immediately not waiting for the server response to improve the UX.
1. (*) Handle `Add` and `Delete` errors so the user can retry

DEMO [ https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it and update it in the PR description

Suggested change
DEMO [ https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/]
[DEMO](https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/)

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, to improve:
Added comments are not displayed, also, the author cannot be just spaces
image

README.md Outdated
@@ -35,3 +35,5 @@ Install Prettier Extention and use this [VSCode settings](https://mate-academy.g
1. Implement comment deletion
- Delete the commnet immediately not waiting for the server response to improve the UX.
1. (*) Handle `Add` and `Delete` errors so the user can retry

[DEMO] (https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this link in the PR description

Suggested change
[DEMO] (https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/)
[DEMO](https://oleksandrakoshyk.github.io/react_dynamic-list-of-posts/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants